When FollowLink is called from the show_tags picker, it searches for the
word that was under the cursor instead of the selected tag. This PR
changes FollowLink so it instead searches for the selected tag.
Signed-off-by: Christopher Sams <cwsams@gmail.com>
With the new callback parameter it becomes necessary to fill the nil arguments
of a function if it is to receive the callback as the last argument
to reproduce bug try creating a new weekly note.
vim.ui.select is meant to be used as an asynchronous operation,
in order to do this, it receives a callback as a third argument.
This commit adjusts check_dir_and_ask to leverage the asynchronous
usage of vim.ui.select, as a side effect to make this work, I also
refactored the code that depends on the function in order to leverage
the asynchronous operations.
References:
- https://github.com/stevearc/dressing.nvim/issues/80#issuecomment-1380734202
- https://github.com/stevearc/dressing.nvim
- https://github.com/neovim/neovim/pull/15771
Fixes:
- https://github.com/renerocksai/telekasten.nvim/issues/266
One reason this bug can sneak into the codebase is because the
default unmodified behavior of vim.ui.select is to use the
:Messages section of neovim to ask for input and this UI is
a synchronous blocking operation. However, this is not the
intended usage of vim.ui.select as presented above.
Some users experience an empty dialog after calling show_tags, when the tag has been selected and a prompt with the files that contain the tag should appear.
My understanding is that the flag will call linkutils.generate_backlink_map to get a list of backlinks. I can't see the purpose for the count in the context of showing tags, so I believe that false should be the value for all cases
